pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
565 stars 304 forks source link

Fix and change a11y tests #1687

Closed gabalafou closed 5 months ago

gabalafou commented 6 months ago

Some of the passing accessibility tests broke because of the way I had implemented the data regression fixtures for pytest-regressions in #1501.

Specifically, some of the data regression fixture files contained the Axe-core version, so when Axe-core was updated, those fixtures became out of sync with the test run.

I decided to scrap the data regression fixture files and instead, I define a function in the test file that filters out violations for Axe-core rules that we want to ignore. Using a function is ultimately more flexible.

gabalafou commented 6 months ago

cc @trallard