pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
565 stars 304 forks source link

BUG - Ensure lists markers colours are visible #1711

Closed trallard closed 5 months ago

trallard commented 5 months ago

Closes #1710

Sets the table colour to --pst-color-text-base instead of the default Bootstrap colour

drammock commented 5 months ago

@trallard I pushed here to get the CIs to run (lint was failing). FYI, seems like maybe your pre-commit hooks aren't set up correctly (or maybe you did this on a new/borrowed computer or something?).

trallard commented 5 months ago

Thank you! I used codespaces for this PR as it was a quick one so will make sure to remember this the next time.

drammock commented 5 months ago

Thank you! I used codespaces for this PR as it was a quick one so will make sure to remember this the next time.

Should we consider https://pre-commit.ci/ to streamline cases like this? I can't recall if we already discussed/rejected that idea here, or if that was a different repo.

trallard commented 5 months ago

+1 on pre-commit.ci

drammock commented 5 months ago

looks good!

Screenshot 2024-02-12 at 15-16-34 Tables — PyData Theme 0 15 3dev0 documentation