search

pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
561 stars 304 forks source link

Some links in the left mobile sidebar act like links in dropdown #1735

Closed gabalafou closed 2 months ago

gabalafou commented 4 months ago

It might be worth following up some of the discussion in #1604, so that we can have a fix that is less of a hack.

_Originally posted by @gabalafou in https://github.com/pydata/pydata-sphinx-theme/pull/1564#discussion_r1520141813_

The same markup is generated for the links in the mobile sidebar as in the desktop header nav bar.

Since the markup was originally written for the header nav bar, it carries over some assumptions to the mobile sidebar that have to be addressed with CSS and JS (for example #1604). Perhaps it's worth a slight refactor.