search

pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
560 stars 303 forks source link

set Codecov verbose flag to true #1743

Closed gabalafou closed 3 months ago

drammock commented 3 months ago

just curious: why re-add the verbose flag here? Codecov upload seems to be working; the CI failure is an actual (or false-positive?) coverage decrease (https://app.codecov.io/gh/pydata/pydata-sphinx-theme/pull/1743/blob/src/pydata_sphinx_theme/__init__.py)

gabalafou commented 3 months ago

Oh hey, sorry, was just trying to debug one of the last workflow runs on #1564.

drammock commented 3 months ago

Oh hey, sorry

don't be! debugging is an endorsed behaviour :)

was just trying to debug one of the last workflow runs on #1564.

I see:

error - 2024-03-18 18:09:33,939 -- Commit creating failed: {"detail":"You do not have permission to perform this action."}

which is different from what we were seeing before #1741

error - 2024-03-14 14:58:12,068 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 705 seconds."}

My guess is either:

  1. it doesn't like the fact that the PR is not into main
  2. it doesn't like the fact that it was opened by you (e.g., your GH account doesn't have a linked codecov account or something... I've seen similar things with CircleCI sometimes)

These are just guesses though, haven't looked very deeply

gabalafou commented 3 months ago

Thanks for looking into it @drammock!

Be aware that #1564 is:

  1. for main
  2. owned by @trallard (and the last commit was by trallard)

Could we merge this PR into #1564 so we can hopefully get more info from the workflow run logs? You can mark #1564 as "change requested" until we revert the verbose flag.

drammock commented 3 months ago

Could we merge this PR into #1564 so we can hopefully get more info from the workflow run logs?

yes of course, sorry I didn't mean to slow you down here!

gabalafou commented 3 months ago

Thank you! And I'm glad you ask questions!