search

pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
600 stars 313 forks source link

Right sidebar section remains even if blank #1744

Closed kathatherine closed 6 months ago

kathatherine commented 6 months ago

Apologies if this has already been discussed. I've looked through the tickets regarding the sidebar changes and can't find anything directly discussing or explaining this, to my knowledge. As of 0.15.0, the right sidebar section remains even if there is no content in it, so the content block remains narrow.

Top image is our production docs, currently pinned to 0.14.4. Bottom is local build on 0.15.2.

image image

There is a workaround for this, using :html_theme.sidebar_secondary.remove: in each page that you don't want to have a blank right sidebar, but it is mildly annoying to now have to use a manual setting for something that was once automatic.

Is this now an intended part of the theme or if this is a bug? Just so I can plan what I need to do to upgrade the theme version. Thanks!

trallard commented 6 months ago

Thanks for opening an issue. This bug is fixed per https://github.com/pydata/pydata-sphinx-theme/pull/1688 and the patch should be available in the next release.