search

pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
560 stars 303 forks source link

fix missing sphinx testing dependencies #1751

Closed drammock closed 3 months ago

drammock commented 3 months ago

cc @trallard this should fix the defusedxml errors. It was added as a new optional dependency to sphinx within the last week. It seems like we were already getting all the other sphinx [test] deps in other ways (just by luck) so strictly speaking I could have just added [test] to the sphinx dev URL, but why leave it fragile if we don't have to.

drammock commented 3 months ago

argh. things that work locally aren't working when run via the action. Will revisit next week, but if anyone knows the right combination of ", ', and { just by looking, feel free to comment/push here

trallard commented 3 months ago

I can sort it out when I am back at work on Tuesday.

drammock commented 3 months ago

OK I think I got it @trallard. The 3.12 CI is still failing, but it's failing at the codecov upload step, not when trying to import defusedxml when running the tests.

trallard commented 3 months ago

Let's merge this as is since the codecov bit is the missing one atm