Raise exception for response codes outside range 200-299

pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community

https://pydata-sphinx-theme.readthedocs.io

BSD 3-Clause "New" or "Revised" License

561 stars 304 forks source link

Closed Czaki closed 1 month ago

Czaki commented 3 months ago

GitHub pages return valid HTML page when an element was removed.

This PR add check for return code to not inject returned HTML if the return code is outside range 200-299.

Carreau commented 1 month ago

I'm joining the conversation late, but this was approved and seem reasonable, i'm going to take some risks and merge.