pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
557 stars 300 forks source link

MAINT: various fixes to print CSS. #1770

Closed Carreau closed 1 month ago

Carreau commented 2 months ago

This should among other fix #1745

When printing this hides

This does not hide the version warning banner as this is currently being worked on in another PR.

I went the route of adding the bootstrap d-print-none, instead of adding custom css rules, I'm happy to do the opposite, but it seem the using bootstrap classes as that seems what is done in other places.

I've also added a break-inside avoid in a few places, mostly to try-to avoid page breaks in the middle of codeblocks.

drammock commented 2 months ago

hmm the defusedxml errors should have been fixed by #1751 ... Oh I see, there's been a sphinx release so now all test runners need it, not just the one running sphinx dev

I'll open another PR to fix that

trallard commented 1 month ago

Merged main to resolve some conflicts. @gabalafou, since you have already reviewed it, feel free to merge the PR once the CI is completed.

Carreau commented 1 month ago

Thanks !