search

pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
600 stars 313 forks source link

Do not generate dropdown in sidebar. #1771

Closed Carreau closed 4 months ago

Carreau commented 5 months ago

This should fix #1735, it is complementary to #1564 but with a different approach.

Instead of generating the same navbar as the fullpage width one, it generate one with no dropdowns, with this, any css that tries to make downtown looks like normal links in html becomes unnecessary.

Carreau commented 5 months ago

unrelated type change removed and pulled in their own PR.

Carreau commented 5 months ago

BTW, every time I push the workflows re-need approval are the workflow settings a bit too agressive ? I though approval were only a one-time thing.

gabalafou commented 5 months ago

BTW, every time I push the workflows re-need approval are the workflow settings a bit too agressive ? I though approval were only a one-time thing.

That's a good question. I don't have access to the workflow settings. @drammock do you?

gabalafou commented 5 months ago

In the meantime, I do have permission to approve and run workflows for a particular PR, so I went ahead and re-ran the workflows on this PR

drammock commented 5 months ago

That's a good question. I don't have access to the workflow settings. @drammock do you?

I just gave @Carreau write access to this repo, which should make the CIs run automatically on his PRs in future. Then I remembered that we usually have a process for this --- opening a PR nominating someone to have access, giving folks time to weigh in. Sorry for subverting the process!

I can still open that PR if folks want, and revoke access if @Carreau gets vetoed, WDYT? FWIW both @trallard and I know @Carreau personally and I trust him to not do anything dangerous here so if folks want to skip the formal vote that's also OK with me.

Carreau commented 5 months ago

I just gave @Carreau write access to this repo, which should make the CIs run automatically on his PRs in future. Then I remembered that we usually have a process for this --- opening a PR nominating someone to have access, giving folks time to weigh in. Sorry for subverting the process!

Thanks, much appreciated. and it's ok if you wish to remove me.

How hard would it be to add a test for this? I'm thinking a test that checks that the sidebar renders the nav without the dropdown markup, whereas the header renders it with.

I'm not too sure, I'll try to understand pytest-regression and how to select the right things in the sidebar.

Carreau commented 5 months ago

Ok, there was no test for the nav of the sidebar, I think I added one in the right place. This should also take care of #1799

drammock commented 5 months ago

@gabalafou you requested changes here, can you take another look and merge if satisfied?

Carreau commented 4 months ago

Thanks !