search

pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
600 stars 313 forks source link

Replace aside tags with div tags when converting rST to HTML #1783

Closed gabalafou closed 4 months ago

gabalafou commented 5 months ago

This is a proof of concept that fixes #1479.

I'm not entirely sure this is a maintainable approach, though. The problem is that if we upgrade Sphinx, then we will need to revisit the methods that this PR overrides to make sure that they aren't missing any features that may or may not have been added in a Sphinx update.

A better approach would be a simple substitution of aside for div tags when the doc pages get written as HTML, but I don't know how to do that.

gabalafou commented 5 months ago

In order for this to be complete, need to also override visit_topic and (maybe) visit_system_message

gabalafou commented 4 months ago

In chat with Tania, we decided not to go forward with this pull request because of my concerns about maintainability.