search

pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
557 stars 300 forks source link

fix version-switcher with dirhtml builder #1795

Closed casperdcl closed 1 month ago

casperdcl commented 2 months ago

Problem: version-switcher suffixes .html even if sphinx was used with the dirhtml builder.

Solution: suffix / instead where necessary.

azeey commented 1 month ago

I was having the same issue and this PR does fix it for me. Thanks @casperdcl!

github-actions[bot] commented 1 month ago

Coverage report

This PR does not seem to contain any modification to coverable code.

Carreau commented 1 month ago

Ok, let's try that. It seem simple enough that I believe it is safe to merge.