search

pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
557 stars 299 forks source link

[pre-commit.ci] pre-commit autoupdate hooks #1848

Closed pre-commit-ci[bot] closed 4 weeks ago

pre-commit-ci[bot] commented 4 weeks ago

updates:

drammock commented 4 weeks ago

@trallard @Carreau AFAICT, the pre-commit CI App and our local pre-commit hooks (run in the CI's lint job) are fighting each other. I don't have sufficient permissions to configure the repo-level app (https://github.com/pydata/pydata-sphinx-theme/settings/installations)

I think the right thing to do is to ignore CIs on this PR and just merge it, and then merge main into e.g. #1850 and hope that the pre-commit CI stops correcting files in a way that makes the lint job fail.

to repro locally the CI lint job failure: 

pre-commit clean
tox -re lint

cc @MridulS

Carreau commented 4 weeks ago

I dont' have enough permission either.

My take is what is ran by pre-commit should not be ran in GH action.

From a few exchange iI had today it seem that a few people are frustrateed by tox+gh-action.

drammock commented 4 weeks ago

the pre-commit CI action is pretty useful for two cases:

  1. making edits to a PR through the GitHub UI, where pre-commit isn't otherwise run
  2. PRs opened by first-time contributors who haven't installed the pre-commit hooks

But anyway since neither of us have permissions to configure/disable, for now maybe let's merge this and hope that it resolves the fight between the action and the hook. WDYT?

trallard commented 4 weeks ago

The easiest is to remove the pre-commit from the CI on GH actions. I just left it there since it was already in our CI and it did not seem ppl had much trouble at the time.

Separate I had already asked folks at NUMFOCUS (since the repo is in the PyData org) while talking to them in person recently to grant maintainers of the theme elevated access to the repo as we keep hitting blockers to change configs and the likes so we have had to resource to ping ppl like Andy Terrel. Shall we surface this again perhaps in the projects channel in the NF Slack?

drammock commented 4 weeks ago

Shall we surface this again perhaps in the projects channel in the NF Slack?

yes please!

cc @jarrodmillman