search

pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
557 stars 300 forks source link

ENH - Update copyright.html to not include the html tags. #1874

Closed Carreau closed 6 days ago

Carreau commented 2 weeks ago

I think it is a mistake to include a tags.

Note that with the exception of the ©, the two translate blocks are almost identical, so I would also be for including the © inside the html copyright to have the same translatable strings.

Closes #1873

drammock commented 2 weeks ago

@trallard the "run tests & display coverage" job seems to be stalling on some (all?) PRs (e.g. here and https://github.com/pydata/pydata-sphinx-theme/pull/1862#issuecomment-2163049257). Do you have time to look into it?

trallard commented 2 weeks ago

That is the coverage comment action, it seems (https://github.com/pydata/pydata-sphinx-theme/actions/workflows/coverage.yml)

The coverage step in the CI workflow seems ok https://github.com/pydata/pydata-sphinx-theme/actions/runs/9483776453/job/26132093990

I can look into this in a bit

trallard commented 6 days ago

This has been approved and CI is green, merging now 🚀