search

pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
557 stars 300 forks source link

Missing aria-current #1886

Open gabalafou opened 1 week ago

gabalafou commented 1 week ago

We should mark the current page in the nav using aria-current.

I couldn't find an issue that already tracks this.

gabalafou commented 1 week ago

Point of clarification: we currently use aria-current in the breadcrumb nav but I wonder if we should apply it to the sidebar (and top bar) nav too.

drammock commented 1 week ago

SGTM. Assuming that the top nav only gets aria-current when user is actually on a top-level page right? (not when on any page within that top-level section)