Card wording hard to read in dark theme

pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community

https://pydata-sphinx-theme.readthedocs.io

BSD 3-Clause "New" or "Revised" License

557 stars 300 forks source link

Card wording hard to read in dark theme #1904

Closed pllim closed 4 hours ago

pllim commented 3 days ago

Example: https://docs.astropy.org/en/latest/

Built with the PyData Sphinx Theme 0.15.4.

pllim commented 3 days ago

For comparison, it was much nicer with 0.15.2: https://docs.astropy.org/en/v6.1.0/

melissawm commented 2 days ago

Hi @pllim !

This is actually coming from your astropy.css file - we had a similar issue with NumPy and SciPy. See below in the red box to the right of the screenshot:

Captura de imagem_20240629_092314

I would recommend cleaning up the astropy.css file to a bare minimum as most of the colors and styles you can now get for free with the PyData Sphinx theme. Here's how we do it at NumPy, for example: https://github.com/numpy/numpy/blob/main/doc/source/_static/numpy.css#L56

I can submit a PR to your docs if that's alright 😄

pllim commented 2 hours ago

@melissawm , thank you very much! I will review the astropy PR you opened. 🙇‍♀️