Open gabalafou opened 3 days ago
Submitting this as a draft until I can hunt down what seems to be some kind of race condition (I'm guessing race condition because sometimes the tests pass locally, sometimes not). Sometimes when running the tests locally, the "scollable-region-focusable" Axe check fails, which shouldn't happen because I am asking Playwright to wait for a sign from the script that adds tabindex=0.
Getting same confusing Axe failure in CI
I think I found the cause of the race condition:
With that order of operations, we get a failure for the scrollable-region-focusable Axe check. But if step 5 comes after 6, the check passes.
I rewrote the Playwright script to wait both for the ipywidget table's container to load and for tabindex="0" to be applied.
Click to see where and how coverage changed
File Statements Missing Coverage Coverage
(new stmts)Lines missing
src/pydata_sphinx_theme
__init__.py
logo.py
short_link.py
toctree.py
translator.py
Project Total
This report was generated by python-coverage-comment-action
Once this PR is merged, running the accessibility checks should execute successfully, with all known failures marked as expected. This should allow us to close #1428 and add the accessibility checks to CI.