pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
595 stars 310 forks source link

Think of deprecating usage of toggle buttons and dropdown in favor of native sphinx collapsible admonition. #1934

Open Carreau opened 2 months ago

Carreau commented 2 months ago

See https://github.com/sphinx-doc/sphinx/pull/12507, sphinx is implementing "native' collapsible admonition,

I know there are a few issue with accessibility for those dropdown and toggle-buttons.

I think it would be a better use of resources to focus on making acessibilty better with the current upstream PR and work to deprecated the usage of sphinx-design and sphinx-toggle-buttons directives in favor of native ones.

trallard commented 2 months ago

I would be in favour of using and improving accessibility on the native collapsible components one that is in Sphinx. That would help also reduce maintenance burden on ourend.

Though we'd need to come up with a depreciation strategy to minimise unwanted/negative impact on our users.