search

pydata / pydata-sphinx-theme

A clean, three-column Sphinx theme with Bootstrap for the PyData community
https://pydata-sphinx-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
592 stars 309 forks source link

Missing variable: zindex-tooltip #1953

Open stefanv opened 1 month ago

stefanv commented 1 month ago

54311e5c09f23612a632ac0b02e9cc6151ffba07 introduces the $zindex-tooltip variable that is undeclared elsewhere.

Carreau commented 1 month ago

I believe this is set by bootstrap

It is going to be properly replaced at build time to 1080 px. I agree that it should likely have a bs- prefix to figure that out.

Screenshot 2024-08-15 at 14 48 24
trallard commented 1 month ago

Yes this is indeed coming from bootstrap and is replaced at compile time. Since this is not pre-pended with a bs- and if you think it's worth for clarity, adding a comment about this would be ok.

stefanv commented 1 month ago

Thanks for the clarification. This broke the compilation of the Scientific Python Hugo Theme, so I suppose it's the first bootstrap variable used this way. I can custom-define it for our theme.