pydata / sparse

Sparse multi-dimensional arrays for the PyData ecosystem
https://sparse.pydata.org
BSD 3-Clause "New" or "Revised" License
598 stars 124 forks source link

API: Add `sort` and `take` functions for COO format #627

Closed mtsokol closed 9 months ago

mtsokol commented 9 months ago

Hi @hameerabbasi,

This PR adds sort and take Array API functions for the COO format to the main namespace. sort function, where looping happens, is numba jitted.

codecov[bot] commented 9 months ago

Codecov Report

Merging #627 (5bd29ad) into main (82fb0d5) will decrease coverage by 0.38%. The diff coverage is 58.57%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #627 +/- ## ========================================== - Coverage 90.57% 90.20% -0.38% ========================================== Files 20 20 Lines 3618 3654 +36 ========================================== + Hits 3277 3296 +19 - Misses 341 358 +17 ```
mtsokol commented 9 months ago

Ok, I think I addressed all comments - the PR is ready for another review.

mtsokol commented 9 months ago

LGTM, feel free to hit the button. 😄

Thanks! Unfortunately I see: "You’re not authorized to merge this pull request."

hameerabbasi commented 9 months ago

LGTM, feel free to hit the button. 😄

Thanks! Unfortunately I see: "You’re not authorized to merge this pull request."

What about now?

mtsokol commented 9 months ago

Merged! Thank you!