Closed mtsokol closed 6 months ago
5 899 tests +2 5 865 :white_check_mark: - 1 3m 18s :stopwatch: -1s 1 suites ±0 34 :zzz: +3 1 files ±0 0 :x: ±0
Results for commit 4c309c73. ± Comparison against base commit 92e80785.
:recycle: This comment has been updated with latest results.
We also need a rebase.
Quick question: since pydata_backend
and finch_backend
are (I assume) private and are only supposed to be used via context manager backend selection, wouldn't it be better to prepend underscores to the directory names?
Sure! I think they can be prepended with an underscore. There will always be backend-specific members, like GCXS only present in pydata_backend
, but importing it is hidden by backend selection mechanism (env-var or context manager).
Replaces #645
Hi @hameerabbasi,
Including the new backend in
pydata/sparse
ended up a bit convoluted, therefore I decided to break this task into smaller steps.Here's the first step which moves existing implementation to
sparse/pydata_backend
directory with tests and adds context manager that tracks backend contextvar. The test suite has a lot of pydata specific calls so it will be a separate effort to make tests common for both backends.I applied all your comments from #645 here.
The next PR will run some stub tests with finch to see that it can be installed and run in CI.