pydata / sparse

Sparse multi-dimensional arrays for the PyData ecosystem
https://sparse.pydata.org
BSD 3-Clause "New" or "Revised" License
585 stars 125 forks source link

API: Enable finch backend for `scipy.sparse` #664

Closed mtsokol closed 4 months ago

mtsokol commented 4 months ago

Hi @hameerabbasi,

Once https://github.com/willow-ahrens/finch-tensor/pull/31 is merged this PR will make sure that scipy.sparse also accepts finch-backend tensors!

github-actions[bot] commented 4 months ago

Test Results

5 923 tests  +10   5 891 :white_check_mark: +12   7m 1s :stopwatch: - 1m 56s     1 suites ± 0      32 :zzz:  -  2      1 files   ± 0       0 :x: ± 0 

Results for commit 017cb7da. ± Comparison against base commit 5bd2df6b.

This pull request removes 6 and adds 16 tests. Note that renamed tests count towards both. ``` sparse.tests.test_backends ‑ test_asarray[BackendType.Finch-coo] sparse.tests.test_backends ‑ test_asarray[BackendType.Finch-csc] sparse.tests.test_backends ‑ test_asarray[BackendType.Finch-csr] sparse.tests.test_backends ‑ test_asarray[BackendType.PyData-coo] sparse.tests.test_backends ‑ test_asarray[BackendType.PyData-csc] sparse.tests.test_backends ‑ test_asarray[BackendType.PyData-csr] ``` ``` sparse.tests.test_backends ‑ test_asarray[BackendType.Finch-coo-C] sparse.tests.test_backends ‑ test_asarray[BackendType.Finch-coo-F] sparse.tests.test_backends ‑ test_asarray[BackendType.Finch-csc-F] sparse.tests.test_backends ‑ test_asarray[BackendType.Finch-csr-C] sparse.tests.test_backends ‑ test_asarray[BackendType.PyData-coo-C] sparse.tests.test_backends ‑ test_asarray[BackendType.PyData-coo-F] sparse.tests.test_backends ‑ test_asarray[BackendType.PyData-csc-F] sparse.tests.test_backends ‑ test_asarray[BackendType.PyData-csr-C] sparse.tests.test_backends ‑ test_scipy_sparse_dispatch[BackendType.Finch-coo-C] sparse.tests.test_backends ‑ test_scipy_sparse_dispatch[BackendType.Finch-coo-F] … ```

:recycle: This comment has been updated with latest results.

mtsokol commented 4 months ago

@hameerabbasi Thank you for reviewing! Could you also cut a new alpha release?

hameerabbasi commented 4 months ago

Done! https://pypi.org/project/sparse/0.16.0a4/