pydata / sparse

Sparse multi-dimensional arrays for the PyData ecosystem
https://sparse.pydata.org
BSD 3-Clause "New" or "Revised" License
581 stars 123 forks source link

[Finch] API: More creation functions #669

Closed mtsokol closed 3 months ago

mtsokol commented 3 months ago

Hi @hameerabbasi,

This PR adds new creation functions that we just added to finch-tensor.

With zeros implemented, array-api-tests suite is able to also test Tensor object namespace, therefore I added a few skips for the test_array_method_signature test, that are rather low priority (such as __dlpack__ or __int__)

github-actions[bot] commented 3 months ago

Test Results

5 923 tests  ±0   5 889 :white_check_mark: ±0   6m 49s :stopwatch: -5s     1 suites ±0      34 :zzz: ±0      1 files   ±0       0 :x: ±0 

Results for commit eac6efc1. ± Comparison against base commit 3bfc2834.

This pull request skips 2 and un-skips 2 tests. ``` sparse.numba_backend.tests.test_compressed ‑ test_reductions_float16[f4-None-sum-kwargs0] sparse.numba_backend.tests.test_coo ‑ test_reductions_float16[f8-1-sum-kwargs0] ``` ``` sparse.numba_backend.tests.test_compressed ‑ test_reductions_float16[i4-None-sum-kwargs0] sparse.numba_backend.tests.test_coo ‑ test_reductions_float16[f8-None-sum-kwargs0] ```

:recycle: This comment has been updated with latest results.

hameerabbasi commented 3 months ago

Thanks @mtsokol! We seem to be missing the bitwise logical functions you added.

mtsokol commented 3 months ago

Done!