Closed mtsokol closed 2 months ago
5 923 tests ±0 5 892 :white_check_mark: ±0 9m 24s :stopwatch: + 2m 33s 1 suites ±0 31 :zzz: ±0 1 files ±0 0 :x: ±0
Results for commit 0f52367e. ± Comparison against base commit 79b9d71d.
:recycle: This comment has been updated with latest results.
I think density could be increased to 0.0001
so we have 100 non-zeros (more realistic?) - I get same performance.
I'd actually like to test the examples as well, to make sure they always work. Can we add something like the following to CI:
# test_examples.sh
for example in $(find ./examples/ -iname *.py); do
python $example
done
# in CI
source test_examples.sh
Alternatively (and preferably) let's move this to the benchmarks.
I added a CI stage for running it.
I can add SDDMM also to the benchmarks, but I prefer to also have examples
separately that can be quickly shared with others and executed in repl, instead of unwrapping asv-specific benchmark code.
Here's a debug output for Finch lazy mode plan:
Let's keep working on this until we see a speedup from fusion. I believe a fusion-based speedup should be achievable here, so it's a good goal to work towards.
Right now in the latest Finch version we have precompilation of a few kernels. This causes a timeout of the first benchmark. Let me fix it.
Thanks @mtsokol!
Hi @hameerabbasi,
This PR adds
SDDMM
example and upgrades Finch to the latest version.[UPDATED 14.05.2024] For my machine, running:
gives: