Closed hameerabbasi closed 2 months ago
Shouldn't we merge it once NumPy 2.0(rc) is ran in the
--pre
job?In logs I see that it's still 1.x: https://github.com/pydata/sparse/actions/runs/9125700838/job/25092447467?pr=681#step:6:160
Installing collected packages: numpy, llvmlite, numba Attempting uninstall: numpy Found existing installation: numpy 1.26.4 Uninstalling numpy-1.26.4: Successfully uninstalled numpy-1.26.4 Attempting uninstall: llvmlite Found existing installation: llvmlite 0.42.0 Uninstalling llvmlite-0.42.0: Successfully uninstalled llvmlite-0.42.0 Attempting uninstall: numba Found existing installation: numba 0.59.1 Uninstalling numba-0.59.1: Successfully uninstalled numba-0.59.1
It doesn't add/test support for NumPy 2.0 yet.
Right -- we first install 1.x and then update. You're seeing the lines for the initial install: https://github.com/pydata/sparse/actions/runs/9125700838/job/25092447467?pr=681#step:6:171
Successfully installed llvmlite-0.43.0rc1 numba-0.60.0rc1 numpy-2.0.0rc2
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #681 +/- ## ========================================== - Coverage 90.21% 90.10% -0.11% ========================================== Files 20 22 +2 Lines 3670 3731 +61 ========================================== + Hits 3311 3362 +51 - Misses 359 369 +10 ```