pydata / sparse

Sparse multi-dimensional arrays for the PyData ecosystem
https://sparse.pydata.org
BSD 3-Clause "New" or "Revised" License
585 stars 125 forks source link

test: Modified index and slice tests in order to vary ranks #743

Closed DeaMariaLeon closed 1 month ago

DeaMariaLeon commented 1 month ago

What type of PR is this? (check all applicable)

Related issues

Checklist


Please explain your changes below.

Original benchmarks used fixed rank

codspeed-hq[bot] commented 1 month ago

CodSpeed Performance Report

Merging #743 will not alter performance

Comparing DeaMariaLeon:bench3 (ec4dc36) with main (45cdc71)

Summary

โœ… 23 untouched benchmarks

๐Ÿ†• 21 new benchmarks โ‰๏ธ 5 (๐Ÿ‘ 5) dropped benchmarks

Benchmarks breakdown

Benchmark main DeaMariaLeon:bench3 Change
๐Ÿ†• test_index_fancy[side=100-rank=1] N/A 923.9 ยตs N/A
๐Ÿ†• test_index_fancy[side=100-rank=2] N/A 816.7 ยตs N/A
๐Ÿ†• test_index_fancy[side=100-rank=3] N/A 3.5 ms N/A
๐Ÿ†• test_index_fancy[side=1000-rank=1] N/A 1.7 ms N/A
๐Ÿ†• test_index_fancy[side=1000-rank=2] N/A 4.5 ms N/A
๐Ÿ‘ test_index_fancy[side=100] 3.5 ms N/A N/A
๐Ÿ†• test_index_fancy[side=500-rank=1] N/A 1.1 ms N/A
๐Ÿ†• test_index_fancy[side=500-rank=2] N/A 1.9 ms N/A
๐Ÿ†• test_index_scalar[side=100-rank=1] N/A 320 ยตs N/A
๐Ÿ†• test_index_scalar[side=100-rank=2] N/A 401.2 ยตs N/A
๐Ÿ†• test_index_scalar[side=100-rank=3] N/A 480.9 ยตs N/A
๐Ÿ†• test_index_scalar[side=1000-rank=1] N/A 322.2 ยตs N/A
๐Ÿ†• test_index_scalar[side=1000-rank=2] N/A 402.3 ยตs N/A
๐Ÿ‘ test_index_scalar[side=100] 481.2 ยตs N/A N/A
๐Ÿ†• test_index_scalar[side=500-rank=1] N/A 323.8 ยตs N/A
๐Ÿ†• test_index_scalar[side=500-rank=2] N/A 403.4 ยตs N/A
๐Ÿ‘ test_index_slice2[side=100] 1.5 ms N/A N/A
๐Ÿ‘ test_index_slice3[side=100] 1.4 ms N/A N/A
๐Ÿ†• test_index_slice[side=100-rank=1] N/A 519.1 ยตs N/A
๐Ÿ†• test_index_slice[side=100-rank=2] N/A 632 ยตs N/A
... ... ... ... ...


:information_source: Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

hameerabbasi commented 1 month ago

Thanks! This should auto-merge when CI passes.

DeaMariaLeon commented 1 month ago

I tried to "acknowledge the performance issues" on codspeed, but I'm lacking the rights to do it. I'm talking about the report's note above:

โš ๏ธ Please fix the performance issues or acknowledge them on CodSpeed.

It's just that the benchmark changed name, and codspeed "thinks" that it's missing. I think we need to fix this in order to merge the PR, as codspeed will block. @hameerabbasi