search

pydata / sparse

Sparse multi-dimensional arrays for the PyData ecosystem
https://sparse.pydata.org
BSD 3-Clause "New" or "Revised" License
598 stars 124 forks source link

bld: Upgrade LLVM version to `19.1.0.rc3` #765

Closed mtsokol closed 2 months ago

mtsokol commented 2 months ago

Hi @hameerabbasi,

This PR updates codebase to LLVM 19.1.0.rc3 compatible version.

hameerabbasi commented 2 months ago

Thanks, LGTM. Let's wait for the 19.1 release before merging this, or a confirmation that it won't happen very soon.

codspeed-hq[bot] commented 2 months ago

CodSpeed Performance Report

Merging #765 will degrade performances by 54.64%

Comparing update-mlir-version (aff52bd) with main (b38606f)

Summary

⚡ 1 improvements ❌ 1 (👁 1) regressions ✅ 338 untouched benchmarks

Benchmarks breakdown

Benchmark main update-mlir-version Change
👁 test_index_fancy[side=100-rank=1-format='coo'] 641.3 µs 1,413.8 µs -54.64%
⚡ test_index_slice[side=100-rank=2-format='gcxs'] 2.9 ms 2.6 ms +10.59%
hameerabbasi commented 2 months ago

There's talk of a possible RC4: https://discourse.llvm.org/t/llvm-19-1-0-final-update-and-possible-rc4/81010

Let's go ahead and merge this, instead of blocking all other PoC work.