search

pydata / xarray

N-D labeled arrays and datasets in Python
https://xarray.dev
Apache License 2.0
3.57k stars 1.07k forks source link

Install numba & numbagg in upstream install #9171

Closed max-sixty closed 3 months ago

max-sixty commented 3 months ago

This fixes the upstream error from no numbagg library being available, though there are other failures

max-sixty commented 3 months ago

This will need to wait until the next numba release, which supports numpy 2.0...

keewis commented 3 months ago

from what I remember, in #7311 we decided not to install numba in the upstream-dev CI because it can't handle any version upgrade of numpy. Do we want to revisit that?

max-sixty commented 3 months ago

from what I remember, in #7311 we decided not to install numba in the upstream-dev CI because it can't handle any version upgrade of numpy. Do we want to revisit that?

Yes, that's a good point — I think this is intractable unless numba tries to be forward-compatible with numpy. So will close.

We'll need another solution for the upstream mypy error, though it's one of many many there...

keewis commented 3 months ago

yeah, someone will have to have a look at the mypy upstream-dev CI at some point. Though now that we actually test the released numpy>=2 in the normal mypy CI (a dependency stopped pinning it), these are also failing now.

max-sixty commented 3 months ago

yeah, someone will have to have a look at the mypy upstream-dev CI at some point.

Yes, mostly tracked in https://github.com/pydata/xarray/issues/9155 — most of the failures are a change in mypy versions rather than our library versions...