pydata / xarray

N-D labeled arrays and datasets in Python
https://xarray.dev
Apache License 2.0
3.58k stars 1.07k forks source link

[pre-commit.ci] pre-commit autoupdate #9202

Closed pre-commit-ci[bot] closed 2 months ago

pre-commit-ci[bot] commented 3 months ago

updates:

keewis commented 3 months ago

we might have to turn off E721, or sprinkle noqa: E721 comments around. The issue here is that we're comparing dtypes with types like str using == / !=. Though maybe we can figure out how to do that with dtypes.isdtype instead?

dcherian commented 3 months ago

There's a few that could be switched to isinstance so let's do that and turn it off?

Example: type(result) == slice