Byte attr support - Githubissues

pydata / xarray

N-D labeled arrays and datasets in Python

https://xarray.dev

Apache License 2.0

3.62k stars 1.09k forks source link

Closed hollymandel closed 2 months ago

hollymandel commented 2 months ago

[ ] Closes #7186
[ ] Adds support for bytes as dataset attributes
[ ] Because h5netcdf does not support arbitrary binaries as attributes, adds a check that the binary is an encoded utf8 free of null characters if this is the engine

max-sixty commented 2 months ago

Thank you!

Could we add a test?

hollymandel commented 2 months ago

I've made the requested changes + cleaned up the commit history

max-sixty commented 2 months ago

Thanks @hollymandel !

I'll merge shortly. Please feel free to add a brief note to whatsnew...