pydata / xarray

N-D labeled arrays and datasets in Python
https://xarray.dev
Apache License 2.0
3.63k stars 1.09k forks source link

Use `map_overlap` for rolling reductions with Dask #9770

Closed phofl closed 1 week ago

phofl commented 1 week ago

This enables Dasks map_overlap for rolling reductions, the previous issues with memory consumption are now handled in map_overlap as far as I can tell

phofl commented 1 week ago

Looks like CI is green, anything I should check here?

cc @dcherian FYI

dcherian commented 1 week ago

I guess this means I can simplify #9720 since we don't need it for the built-in reductions?

phofl commented 1 week ago

I guess this means I can simplify https://github.com/pydata/xarray/pull/9720 since we don't need it for the built-in reductions?

unfortunately no, more than one windowing dim takes the construct path :(

phofl commented 1 week ago

The doc build thing is unrelated

max-sixty commented 1 week ago

Looks good!

phofl commented 1 week ago

Failures seem unrelated