Closed aktech closed 7 years ago
Can you please use default test standards? We can go ahead with Django's TestCase or pytest. Please let me know which one you'd like, because that is what we'll be using in entire project.
I think pytest
is better than Django's default TestCase
Have a look at [1]
Also, please add doc-string
Doctstrings are already added for all the methods, excepts for test methods.
it would help others to quickly understand your code.
Understanding tests using comments/doctring is a myth. Comments often lies but code doesn't. Its more important to write self documenting tests rather than writing comments/doctring to make the reader understand it. Have a look at [2][3]
That's the reason, why all the test_methods are very explicit in their naming to make them self documenting.
[1] https://pytest-django.readthedocs.io/en/latest/#why-would-i-use-this-instead-of-django-s-manage-py-test-command [2] http://ricardogeek.com/docs/clean_code.pdf (Comments chapter) [3] http://stackoverflow.com/questions/1726622/how-should-unit-tests-be-documented
requirements.txt