Some updates to pyproject.toml formatting and ruff rules

pydev-guide / pyrepo-copier

Template for creating a new python repository

BSD 3-Clause "New" or "Revised" License

7 stars 3 forks source link

Some updates to pyproject.toml formatting and ruff rules #21

Closed tlambert03 closed 1 year ago

tlambert03 commented 1 year ago

mostly formatting, but also adds:

https://docs.astral.sh/ruff/rules/#flake8-type-checking-tch - something I think is almost always good to have
https://docs.astral.sh/ruff/rules/#flake8-tidy-imports-tid - commented out... slightly opinionated, but something I always enable

jdeschamps commented 1 year ago

Sounds good, love the type checking!

Why deactivate tidy-import by default?

tlambert03 commented 1 year ago

Oh I don't know 😂 I guess hesitant to be too draconian since that one is more opinionated by banning deep relative imports. But I guess there's plenty of opinion in here already. Would you just enable it?

jdeschamps commented 1 year ago

It's tough to define the threshold for "too opinionated". 😄

But the rule is autofixable and should not make non-specialists tear their hair out, so I'd have a tendency to include it.

tlambert03 commented 1 year ago

did it :)

jdeschamps commented 1 year ago

Cool!

One note: in pyproject.toml, there is a typo: use_precommit should be use_pre_commit!