search

pydicom / deid

best effort anonymization for medical images using python
https://pydicom.github.io/deid/
MIT License
140 stars 43 forks source link

Adding ability to specify a filter with REMOVE #124

Closed vsoch closed 4 years ago

vsoch commented 4 years ago

Currently, REMOVE can handle a func:, however since we are returning a boolean, we can easily also support the already existing filters that return a boolean (contains, equals, etc.) This change will allow for those filters. This will address #123, pinging @wetzelj

Signed-off-by: vsoch vsochat@stanford.edu

Questions that require more discussion or to be addressed in future development:

vsoch commented 4 years ago

Yeah I was just thinking about this too - I was grabbing the filters from the list already derived, but I don't think those particular filters make sense. I'm going to remove them.

vsoch commented 4 years ago

oops didn't mean to close it.

vsoch commented 4 years ago

https://pypi.org/project/deid/0.1.41/

vsoch commented 4 years ago

@wetzelj let me think about your comment:

Regarding the plan forward... #118 is really one of the higher priority issues from our standpoint, but if you think that #119 should be done first, that's okay too.

In that adding private tags will mean parsing over the tag objects (which reveal data elements) I'm actually thinking that these two separate issues need to be addressed at the same time - we will be able to easily loop over private tags if the get/set is available. I can't promise starting on this today, but soon!

wetzelj commented 4 years ago

No problem! I appreciate all of your work on this!