pydicom / deid

best effort anonymization for medical images using python
https://pydicom.github.io/deid/
MIT License
140 stars 43 forks source link

Fix/155 change to return results from detect when recipe does not contain filters #156

Closed mjcbello closed 3 years ago

mjcbello commented 3 years ago

Description

Related issues: #155

Change to return results from detect when recipe does not contain filters.

Checklist

Open questions

Questions that require more discussion or to be addressed in future development:

wetzelj commented 3 years ago

@vsoch - I have no clue what we did to include all of those remote-tracking merges... Let us know if we should do something different.

vsoch commented 3 years ago

When we merge PRs, I believe we squash and merge. So likely what you did here is rebase off of your master (with the older commits) - the changes you see are represented in master here, but since the commits are not, they appear here. If we squash and merge it should get rid of them all and just add one commit (and I'll ensure that the message doesn't include the old ones). And next time what you would want to do is generally always have your master in sync with deid master, meaning to never do a PR from your master to deid.