search

pydicom / deid

best effort anonymization for medical images using python
https://pydicom.github.io/deid/
MIT License
140 stars 43 forks source link

Dependence `pydicom` version too low #171

Closed dipterix closed 3 years ago

dipterix commented 3 years ago

Thanks for developing such great package!

I was experimenting with DICOM editing the other day. However, I encountered problem when converting DICOM from YBR_FULL_422 to RGB color space. This feature has been added to pydicom since version 1.4, but deid still requires pydicom=1.3.

I resolve the issue by forcing pip to install the newest version of pydicom. However, I still want to ask is there any reason not to bump the version requirement, like incompatibility issues?

Thanks :)

vsoch commented 3 years ago

Yes that would work! If you'd like to open a PR I can review it. We would want to bump the version of deid (deid/version.py) and add a note to the change log.

vsoch commented 3 years ago

Ping @dipterix !

wetzelj commented 3 years ago

For what it's worth - we've been using pydicom 2.1.1 with deid for several months now and have not experienced any issues. @dipterix , @vsoch - Do you want me to create this PR? If so, I see that version 2.1.2 has been released. While we haven't been testing/using this version do you want me to move pydicom to 2.1.2 or set it to what I can comfortably say has been tested (2.1.1)?

vsoch commented 3 years ago

@wetzelj let's set it to the version that has been tested. If you have bandwidth, a PR would be great! I would have time over the weekend.

dipterix commented 3 years ago

Thanks @wetzelj , I'm not that familiar with python. It'll be great if you can help :)

vsoch commented 3 years ago

@dipterix this is merged into the master branch and will be available with the next release! :partying_face: we have a few other bug fixes coming in soon.

vsoch commented 3 years ago

Going to close here since it's addressed - look out for a release in the next few days (or just use master!)