search

pydicom / deid

best effort anonymization for medical images using python
https://pydicom.github.io/deid/
MIT License
140 stars 43 forks source link

Adding Multivalued Fields to %values Lists #174

Closed wetzelj closed 3 years ago

wetzelj commented 3 years ago

When fields specified within recipe file %values lists contain a list of items, the addition of the Multi-value value to the values array causes an exception (Exception: unhashable type: 'MultiValue').

I believe that this can be corrected checking the type of the value first - if it is MultiValue, we can use set.Update() to update the values list instead of using set.Add().

I've committed a possible fix to the wetzelj/deid INFOR-831 branch.

vsoch commented 3 years ago

@wetzelj let's take these one by one! If there are easy fixes (like the one) let's do a PR from your branch and bumping the version. More complex issues (or ones you want my help with) I could take a look in an evening or weekend.

wetzelj commented 3 years ago

@vsoch Sounds good... it's on its way

vsoch commented 3 years ago

This is all set.