pydicom / deid

best effort anonymization for medical images using python
https://pydicom.github.io/deid/
MIT License
140 stars 43 forks source link

Add codespell to CI to catch typos early #187

Closed DimitriPapadopoulos closed 2 years ago

DimitriPapadopoulos commented 2 years ago

Description

Run codespell in CI to catch typos early on.

Use GitHub Actiosn with actions-codespell.

Related PR: #185

Checklist

vsoch commented 2 years ago

Good idea! Please use an exact sha instead of a branch or tag so it's not a moving target.

DimitriPapadopoulos commented 2 years ago

For what it's worth, it's supposed to be used like this:

uses: codespell-project/actions-codespell@master

See https://github.com/codespell-project/actions-codespell#usage

DimitriPapadopoulos commented 2 years ago

But I agree there is a risk.

vsoch commented 2 years ago

Yes I'm aware how GitHub actions work - for actions that I don't control my preference is to use a non moving target. A commit sha, and not a branch or release tag.

DimitriPapadopoulos commented 2 years ago

OK, I have used the current commit.

vsoch commented 2 years ago

Perfect! I think you just need to provide the entire sha and it will work.

vsoch commented 2 years ago

Thanks! This will prevent my future misspellings :)

DimitriPapadopoulos commented 2 years ago

In the future, false positives can be added to .github/codespell_ignore_words.txt. Hopefully there won't be many.