pydicom / deid

best effort anonymization for medical images using python

https://pydicom.github.io/deid/

MIT License

138 stars 43 forks source link

Fix warnings #218

Closed jstorrs closed 1 year ago

jstorrs commented 1 year ago

Most warnings relate to value vs VR mismatches.

cdbrain1.dcm contained invalid LO values (too long)
PatientIdentityRemoved is CS (code string) and must be YES or NO
A number of LO values that are too long (may not exceed 64 char)
Various other mismatches (UI can't be free-form text, etc)
Use tobytes() instead of tostring() for PixelData

Description

Related issues: # (issue)

Please include a summary of the change(s) and if relevant, any related issues above.

Checklist

[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] My code follows the style guidelines of this project

Open questions

Questions that require more discussion or to be addressed in future development:

vsoch commented 1 year ago

This is great! I should be able to review in the evening after work.