pydicom / deid

best effort anonymization for medical images using python
https://pydicom.github.io/deid/
MIT License
142 stars 44 forks source link

Add/remove keep behavior (Previous PR #199 - 0.2.29 rc) #237

Closed wetzelj closed 1 year ago

wetzelj commented 1 year ago

Description

Related issues: #197, #198, #204,

Whitelisting was not possible for replacing. Now fields being replaced or jittered are excluded from removal (either REMOVE ALL or REMOVE SomeField).

It is done using separate property and private variable to keep result (lazy eval).

Made clarification regarding KEEP list - those fields are being removed from field list to process, meaning that KEEP SomeField + REPLACE SomeField ... won't work, as kept field is being excluded from list of fields to process for other actions.

Added tests. Bumped release candidate number and changelog (+small fix for previous change)

Minor docs update.

Checklist

Open questions

Questions that require more discussion or to be addressed in future development:

vsoch commented 1 year ago

Thanks @wetzelj !