search

pydicom / deid

best effort anonymization for medical images using python
https://pydicom.github.io/deid/
MIT License
142 stars 44 forks source link

Possible incorrect coordinate definition #249

Closed wetzelj closed 1 year ago

wetzelj commented 1 year ago

While reviewing the default deid.dicom file I noticed one greylist filter entry which I believe was incorrectly changed from coordinates to ctpcoordinates.

Stanford Medical Center LightSpeed VCT # (Roger Goldman)

If you agree, I'll submit a PR with this change.

vsoch commented 1 year ago

Yes looks erroneous - sorry that was likely me!

wetzelj commented 1 year ago

Do you want a version bump and changelog entry on this?

vsoch commented 1 year ago

I think this tweak would be OK to merge into main, and either we can wait for the next release (and no bumps but maybe a note) or if you think it's actively hurting someone's pipeline we can do a bump/note. Up to you!

wetzelj commented 1 year ago

I think it's fine to merge into main and then wait for the next release.

vsoch commented 1 year ago

Fixed with #250 thanks @wetzelj !