search

pydicom / deid

best effort anonymization for medical images using python
https://pydicom.github.io/deid/
MIT License
142 stars 44 forks source link

Handle breaking change with pydicom 3 #266

Open sammaxwellxyz opened 5 days ago

sammaxwellxyz commented 5 days ago

recent pydicom release includes breaking change

https://github.com/pydicom/pydicom/releases/tag/v3.0.0

the install requires needs an upper bound or the code updated, a particular breaking change is the attempted use of read_file from dicom/header.py

vsoch commented 5 days ago

The change / fix seems pretty small - change read_file to dcmread. Would you care to PR to update the library here? We will need to do another more major bump in terms of version as well to indicate it is a breaking change.

sammaxwellxyz commented 5 days ago

Nice, will put that together, in the meantime I created a PR for capping the version if your prefer https://github.com/pydicom/deid/pull/267, by all means dismiss :)