search

pydicom / pynetdicom

A Python implementation of the DICOM networking protocol
https://pydicom.github.io/pynetdicom
MIT License
500 stars 176 forks source link

TLS 1.3 support #929

Closed pcanas closed 3 months ago

pcanas commented 4 months ago

I was wondering whether there is an estimated roadmap for this feature.

scaramallion commented 4 months ago

It's done, will be in the next release.

gsmethells commented 3 months ago

Will there be documentation included with the release on how to use TLS during DICOM Association negotiations? Or are there already for TLSv1.2 and I missed them?

scaramallion commented 3 months ago

The Association section in the User Guide has it (SCP, SCU). I need to remove those warnings about 1.3.

Essentially just follow the Python docs for setting up your valid SSL context ssl_cx, then use either:

assoc = ae.associate("127.0.0.1", 11112, tls_args=(ssl_cx, None))  # SCU
server = ae.start_server(("127.0.0.1", 11112), block=False, ssl_context=ssl_cx)  # SCP
pcanas commented 3 months ago

It's done, will be in the next release.

@scaramallion When is the next release expected?

scaramallion commented 3 months ago

I'm not sure, I've been thinking of just putting one out even though there are a few issues I'd like to sort out. I should have a fair amount of free time next week, so maybe then.

scaramallion commented 3 months ago

Done