search

pydio / pydio-core

Pydio 8 official repository
https://pydio.com
GNU Affero General Public License v3.0
867 stars 289 forks source link

Fix Sort By when using pagination #1300

Closed olivierapex6 closed 7 years ago

olivierapex6 commented 7 years ago

Hi we just wrote that code to fix the Sort By , when using the pagination. The error code that we have was ".foreach is not a function" and then blank page. This code is using a FOR loop and drain the object inside the object properly. Please push that code

cdujeu commented 7 years ago

Hi, i'll push a proper patch for that part (not exactly the same as yours). However, are you able to actually revert the sorting (asc/desc) when selecting the same current sorting? i think this is broken too

olivierapex6 commented 7 years ago

Hi Charles

Yes, I confirm, asc/desc is working fine now.

cdujeu commented 7 years ago

just pushed some code, can you test mine?

cdujeu commented 7 years ago

it's cleaner, as we don't want to access the "_object" of the old side prototypeJS hash maps, but use pure javascript Map() instead

olivierapex6 commented 7 years ago

Hi Charles.

Yes it is also working fine with your commit.

Thanks for your help.