pydio / pydio-core

Pydio 8 official repository
https://pydio.com
GNU Affero General Public License v3.0
867 stars 289 forks source link

Pixlr plugin still redirect to http while host is https #1371

Closed bitsandnumbers closed 7 years ago

bitsandnumbers commented 7 years ago

... thus creating a mixed contents issue in the web browser and preventing Pixlr to open. We get a white page instead of the editor ...

So basically the Pixlr plugin try to open "http://pixlr.com" instead of "https://pixlr.com" when Pydio host is in https.

The strange thing is that PixlrEditor.php has the right "https" string inside the PHP class, so it should not happen. It could be an issue on Pixlr's end.

Workaround right now is to disable mixed contents protection in the web browser, which is a different operation depending on the browser. Check the manual of your browser for help with that.

Steps to reproduce :

cdujeu commented 7 years ago

Seems like Pixlr is sending back http:// whatever we ask Can you try that, in plugins/editor.pixlr/PixlrEditor.php Line 130, replace the existing $response = $response .... code with

            // Make sure we load the https
            $redirect = $postResponse->getHeader("Location");
            $redirect = str_replace("http://", "https://", $redirect);
            // Send redirect Header
            $response = $response
                ->withStatus(302)
                ->withHeader("Location", $redirect);

I think it does the job, can you confirm?

bitsandnumbers commented 7 years ago

Hi @cdujeu , thank you for the answer, but I no longer use pydio. I was using it for work but the desktop sync didn't suit my needs. It's a shame because everything else was very good. So, I cannot give any more feedback about this issue. Sorry.

cdujeu commented 7 years ago

ok np, thanks