pydiverse / pydiverse.pipedag

A data pipeline orchestration library for rapid iterative development with automatic cache invalidation allowing users to focus writing their tasks in pandas, polars, sqlalchemy, ibis, and alike.
https://pydiversepipedag.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
15 stars 2 forks source link

Get rid of `ibm_db_sa_fix_name` hack #94

Closed NMAC427 closed 1 year ago

NMAC427 commented 1 year ago

Our issues with IBM DB2 were caused by using compiler.preparer.quote_identifier instead of compiler.preparer.quote. Unlike quote, quote_identifier doesn't check if a name should get quoted or not. Because in SQLAlchemy all lowercase identifiers are viewed as case insensitive (ref), this resulted in our custom DDL statements interacting incorrectly with SQLAlchemy.