pyenv-win / pyenv-win-venv

A CLI to manage virtual envs with pyenv-win
Apache License 2.0
78 stars 8 forks source link

fix: Suppress git output when checking if pyenv-win-venv was git installed #4

Closed cderv closed 1 year ago

cderv commented 1 year ago

Using a redirect to suppress all streams

https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_redirection?view=powershell-7.2#example-5-suppress-all-write-host-and-information-stream-data

I only did it here because it was clear we don't want any stderr as we are deciding what to do based on error or not.

There is a | Out-Null after that will have the same behavior, but in this case we probably want to report error.

Fixes #3

arzkar commented 1 year ago

Looks good to me. Also update the version to 0.5.3 in the .version file. I will merge it after that. Thanks for the PR.