pyenv / pyenv-installer

This tool is used to install `pyenv` and friends.
MIT License
3.96k stars 428 forks source link

Fix faulty condition on variable length #142

Closed rli closed 1 year ago

rli commented 1 year ago
bash-5.2# curl -s -S -L https://raw.githubusercontent.com/pyenv/pyenv-installer/master/bin/pyenv-installer | bash -x
+ bash -x
+ curl -s -S -L https://raw.githubusercontent.com/pyenv/pyenv-installer/master/bin/pyenv-installer
+ set -e
+ '[' -n '' ']'
+ '[' -z '' ']'
+ export PYENV_ROOT=/root/.pyenv
+ PYENV_ROOT=/root/.pyenv
+ '[' -d /root/.pyenv ']'
+ command -v git
+ '[' -n '' ']'
+ '[' -n ']'
+ GITHUB=git@github.com:
+ checkout git@github.com:pyenv/pyenv.git /root/.pyenv master
+ '[' -d /root/.pyenv ']'
+ git -c advice.detachedHead=0 clone --branch master --depth 1 git@github.com:pyenv/pyenv.git /root/.pyenv
Cloning into '/root/.pyenv'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
+ failed_checkout git@github.com:pyenv/pyenv.git
+ echo 'Failed to git clone git@github.com:pyenv/pyenv.git'
Failed to git clone git@github.com:pyenv/pyenv.git
+ exit -1
native-api commented 1 year ago

Okay, my bad, I missed that in https://github.com/pyenv/pyenv-installer/pull/138.

Looks like we do need CI here as well.

Thanks for a fast fix!