search

pyenv / pyenv-virtualenv

a pyenv plugin to manage virtualenv (a.k.a. python-virtualenv)
MIT License
6.18k stars 399 forks source link

Add activate/deactivate hooks #452

Closed joshfrench closed 1 year ago

joshfrench commented 1 year ago

activate/deactivate hooks have been discussed several times but I haven't seen a PR, so... here's one :)

There are two test failures in test/activate and test/deactivate that I think are just me not fully understanding the stub system, do you mind taking a look and pointing me in the right direction? Thanks so much!

Past discussions:

  1. Closes https://github.com/pyenv/pyenv-virtualenv/issues/428
  2. https://github.com/pyenv/pyenv-virtualenv/issues/55
  3. https://github.com/pyenv/pyenv/issues/2337
native-api commented 1 year ago

@pyenv/pyenv-core-maintainers and especially @yyuu : any second opinions on the hook invocation placement?

native-api commented 1 year ago

@joshfrench Thank you for your contribution!