search

pyepics / newportxps

python support code for NewportXPS drivers
BSD 2-Clause "Simplified" License
20 stars 17 forks source link

Bug in ftp_wrapper #7

Closed Nico-Helmi closed 3 years ago

Nico-Helmi commented 3 years ago

Hello,

I wanted to use your module to control a Newport XPS-D. After having problems establishing the sftp connection I finally found the reason: In the ftp_wrapper.py file, the "connect" function trys to establish a connection to the XPS using "username=self.username" and "password=self.username" (Line 75). The latter should be changed to "password=self.password".

Kind regards, Nico

newville commented 3 years ago

@Nico-Helmi Oh, good catch - thanks. PR would be welcome...

Nico-Helmi commented 3 years ago

Sure, I can (hopefully) do that! I'm new to Github so I did not think of that.

newville commented 3 years ago

fixed with #8