pyet-org / pyet

:sunflower: pyet is a Python package to estimate reference and potential evaporation.

https://pyet.readthedocs.io/

MIT License

130 stars 34 forks source link

removed extra argument given #78

Open anshuverma2000 opened 7 months ago

anshuverma2000 commented 7 months ago

Short Description

Add a short description describing the pull request (PR) here.

Checklist before PR can be merged:

[ ] closes issue #xxxx
[ ] is documented
[ ] Format code with Black formatting
[ ] type hints for functions and methods
[ ] tests added / passed
[ ] Example Notebook (for new features)
[ ] Remove output for all notebooks with changes

mvremec commented 7 months ago

Thank you both for your contributions and for identifying the error! I just returned from holiday and will review the materials as soon as possible.

I am proposing the following additions to the Checklist before this PR can be merged:

[ ] Add a Notebook outlining the different input options available for all methods. #77
[ ] Update the documentation on ReadTheDocs per PM ASCE standards. #70
[ ] Support Both 1D and 2D Latitude Inputs for Hargreaves Calculation: Modify the function to handle latitude arrays in both one-dimensional and two-dimensional forms. Include tests for 1D and 2D latitude inputs. #65

mvremec commented 5 months ago

Hi @anshuverma2000,

Thank you for catching the extra argument! I'd appreciate your insights on a couple of other points to help us address the issues effectively:

Input Data Type: Could you confirm whether you are using xarray.DataArray or pandas.Series as input? This will help us understand the context better.
Error Details: Can you provide more specifics about when and under what circumstances the error with NaNs occurred? Thank you for your collaboration!

Best, Matevz